-
-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed to remove a confusing help note about Doctrine #56
Proposed to remove a confusing help note about Doctrine #56
Conversation
Then leave that to Symfony docs and add a link to the docs in this recipe, because it's important to have server version. The server version is important because else Doctrine performs a query to check server version and adapt container compilation depending on the server version. Check Doctrine/DBAL/Platforms directory and see the different classes that can depend on the platform's version. |
Let's include just one URL where the whole string - including serverVersion is explained... likely a symfony docs page as you said. And if we don't have it already, what about a post install message that says to update the settings in this file? |
I believe the need for this is removed in the next version of Doctrine? |
Maybe :). Is the extra query to determine the version only run once when the container is being built? If so, paas will have a problem - they'll build the container before the db is ready. Or, is the extra query on every request? That's kind of lame, but more of a perf optimization. Or, does Doctrine run the query once at runtime and then cache it after? If that's the case, I don't see any reason to keep this. If someone has a few minutes to run down those answers, that would help (I'm on my phone!) |
The extra query is run only on container compilation to determine which driver/platform will be used by Doctrine IIRC |
@Pierstoval If it's run on container compilation, then the |
The need for the option should be solved in Doctrine DBAL (see the linked issues above). |
No, the changes in DBAL does not remove the need for the |
Closing because this was reworded as part of #258. |
I originally proposed to add this help note:
Now I propose to remove it because it's confusing:
I think this option requires a lengthy explanation to be really understood, so maybe we should leave that for Symfony Docs.